From 91d04b035e73977a758b688f4ac9161cf13b307c Mon Sep 17 00:00:00 2001
From: arnaudlabourel <arnaud.labourel@univ-amu.fr>
Date: Mon, 23 Oct 2023 18:13:27 +0200
Subject: [PATCH] updated gradle config

---
 build.gradle                              | 11 ++++++++++-
 src/main/java/FirefighterApplication.java |  9 ++++-----
 src/main/java/controller/Controller.java  | 12 ++++++++----
 src/main/java/model/FirefighterBoard.java |  2 +-
 4 files changed, 23 insertions(+), 11 deletions(-)

diff --git a/build.gradle b/build.gradle
index ba8d575..d1f46e6 100644
--- a/build.gradle
+++ b/build.gradle
@@ -2,10 +2,11 @@
 plugins {
     id 'application'
     id "org.openjfx.javafxplugin" version "0.0.14"
+    id 'com.github.johnrengelman.shadow' version '8.1.1'
 }
 
 javafx {
-    version = "20"
+    version = "21"
     modules = [ 'javafx.controls', 'javafx.fxml' ]
 }
 
@@ -29,4 +30,12 @@ test {
 
 application {
     mainClass.set("FirefighterApplication")
+}
+
+jar {
+    manifest {
+        attributes("Implementation-Title": project.name,
+                "Implementation-Version": version,
+                "Main-Class": application.mainClass)
+    }
 }
\ No newline at end of file
diff --git a/src/main/java/FirefighterApplication.java b/src/main/java/FirefighterApplication.java
index b666b63..e43ebd9 100644
--- a/src/main/java/FirefighterApplication.java
+++ b/src/main/java/FirefighterApplication.java
@@ -5,7 +5,6 @@ import javafx.fxml.FXMLLoader;
 import javafx.scene.Parent;
 import javafx.scene.Scene;
 import javafx.stage.Stage;
-import model.FirefighterBoard;
 
 import java.io.IOException;
 import java.net.URL;
@@ -13,10 +12,10 @@ import java.net.URL;
 public class FirefighterApplication extends Application {
   private static final String VIEW_RESOURCE_PATH = "/view/view.fxml";
   private static final String APP_NAME = "Firefighter simulator";
-  private static final int ROW_COUNT = 50;
-  private static final int COLUMN_COUNT = 50;
-  private static final int SQUARE_WIDTH = 20;
-  private static final int SQUARE_HEIGHT = 20;
+  private static final int ROW_COUNT = 20;
+  private static final int COLUMN_COUNT = 20;
+  private static final int SQUARE_WIDTH = 50;
+  private static final int SQUARE_HEIGHT = 50;
   public static final int INITIAL_FIRE_COUNT = 3;
   public static final int INITIAL_FIREFIGHTER_COUNT = 6;
 
diff --git a/src/main/java/controller/Controller.java b/src/main/java/controller/Controller.java
index fed82dd..c4e3232 100644
--- a/src/main/java/controller/Controller.java
+++ b/src/main/java/controller/Controller.java
@@ -27,6 +27,10 @@ public class Controller {
 
   public static final int PERIOD_IN_MILLISECONDS = 50;
   @FXML
+  public Button restartButton;
+  @FXML
+  public Button oneStepButton;
+  @FXML
   private ToggleButton pauseToggleButton;
   @FXML
   private ToggleButton playToggleButton;
@@ -99,15 +103,15 @@ public class Controller {
     timeline.pause();
   }
 
-  public void pauseToggleButtonAction(ActionEvent actionEvent) {
+  public void pauseToggleButtonAction() {
     this.pause();
   }
 
-  public void playToggleButtonAction(ActionEvent actionEvent) {
+  public void playToggleButtonAction() {
     this.play();
   }
 
-  public void restartButtonAction(ActionEvent actionEvent) {
+  public void restartButtonAction() {
     this.pause();
     board.reset();
     pauseToggleButton.setSelected(true);
@@ -121,7 +125,7 @@ public class Controller {
     repaintBoard();
   }
 
-  public void oneStepButtonAction(ActionEvent actionEvent) {
+  public void oneStepButtonAction() {
     this.pause();
     updateBoard();
   }
diff --git a/src/main/java/model/FirefighterBoard.java b/src/main/java/model/FirefighterBoard.java
index 35a6b28..910e036 100644
--- a/src/main/java/model/FirefighterBoard.java
+++ b/src/main/java/model/FirefighterBoard.java
@@ -82,9 +82,9 @@ public class FirefighterBoard implements Board<List<ModelElement>> {
     for (Position firefighterPosition : firefighterPositions) {
       Position newFirefighterPosition = neighborClosestToFire(firefighterPosition);
       result.add(firefighterPosition);
-      result.add(newFirefighterPosition);
       firefighterNewPositions.add(newFirefighterPosition);
       extinguish(newFirefighterPosition);
+      result.add(newFirefighterPosition);
       List<Position> neighborFirePositions = neighbors(newFirefighterPosition).stream().filter(firePositions::contains).toList();
       for(Position firePosition : neighborFirePositions)
         extinguish(firePosition);
-- 
GitLab