Skip to content
Snippets Groups Projects
Commit 814175a9 authored by LABOUREL Arnaud's avatar LABOUREL Arnaud
Browse files

some renaming of methods for clarity

parent ba6f7943
No related branches found
No related tags found
No related merge requests found
...@@ -67,10 +67,10 @@ public class Controller { ...@@ -67,10 +67,10 @@ public class Controller {
updatedSquares.add(new Pair<>(updatedPosition, viewElement)); updatedSquares.add(new Pair<>(updatedPosition, viewElement));
} }
grid.repaint(updatedSquares); grid.repaint(updatedSquares);
updateLabel(board.stepNumber()); updateGenerationLabel(board.stepNumber());
} }
private void repaintBoard(){ private void repaintGrid(){
int columnCount = board.columnCount(); int columnCount = board.columnCount();
int rowCount = board.rowCount(); int rowCount = board.rowCount();
ViewElement[][] viewElements = new ViewElement[rowCount][columnCount]; ViewElement[][] viewElements = new ViewElement[rowCount][columnCount];
...@@ -78,7 +78,7 @@ public class Controller { ...@@ -78,7 +78,7 @@ public class Controller {
for(int row = 0; row < rowCount; row++) for(int row = 0; row < rowCount; row++)
viewElements[row][column] = getViewElement(board.getState(new Position(row, column))); viewElements[row][column] = getViewElement(board.getState(new Position(row, column)));
grid.repaint(viewElements); grid.repaint(viewElements);
updateLabel(board.stepNumber()); updateGenerationLabel(board.stepNumber());
} }
private ViewElement getViewElement(List<ModelElement> squareState) { private ViewElement getViewElement(List<ModelElement> squareState) {
...@@ -120,14 +120,14 @@ public class Controller { ...@@ -120,14 +120,14 @@ public class Controller {
this.pause(); this.pause();
board.reset(); board.reset();
pauseToggleButton.setSelected(true); pauseToggleButton.setSelected(true);
repaintBoard(); repaintGrid();
} }
public void initialize(int squareWidth, int squareHeight, int columnCount, public void initialize(int squareWidth, int squareHeight, int columnCount,
int rowCount, int initialFireCount, int initialFirefighterCount) { int rowCount, int initialFireCount, int initialFirefighterCount) {
grid.initialize(squareWidth, squareHeight, columnCount, rowCount); grid.initialize(squareWidth, squareHeight, columnCount, rowCount);
this.setModel(new FirefighterBoard(columnCount, rowCount, initialFireCount, initialFirefighterCount)); this.setModel(new FirefighterBoard(columnCount, rowCount, initialFireCount, initialFirefighterCount));
repaintBoard(); repaintGrid();
} }
public void oneStepButtonAction() { public void oneStepButtonAction() {
...@@ -135,7 +135,7 @@ public class Controller { ...@@ -135,7 +135,7 @@ public class Controller {
updateBoard(); updateBoard();
} }
private void updateLabel(int value){ private void updateGenerationLabel(int value){
generationNumberLabel.setText(Integer.toString(value)); generationNumberLabel.setText(Integer.toString(value));
} }
} }
\ No newline at end of file
...@@ -10,10 +10,10 @@ public class FirefighterBoard implements Board<List<ModelElement>> { ...@@ -10,10 +10,10 @@ public class FirefighterBoard implements Board<List<ModelElement>> {
private final int rowCount; private final int rowCount;
private final int initialFireCount; private final int initialFireCount;
private final int initialFirefighterCount; private final int initialFirefighterCount;
List<Position> firefighterPositions; private List<Position> firefighterPositions;
Set<Position> firePositions; private Set<Position> firePositions;
List<Position> firefighterNewPositions; private int step = 0;
int step = 0; private final Random randomGenerator = new Random();
public FirefighterBoard(int columnCount, int rowCount, int initialFireCount, int initialFirefighterCount) { public FirefighterBoard(int columnCount, int rowCount, int initialFireCount, int initialFirefighterCount) {
this.columnCount = columnCount; this.columnCount = columnCount;
...@@ -33,7 +33,7 @@ public class FirefighterBoard implements Board<List<ModelElement>> { ...@@ -33,7 +33,7 @@ public class FirefighterBoard implements Board<List<ModelElement>> {
} }
private Position randomPosition() { private Position randomPosition() {
return new Position((int) (Math.random() * rowCount), (int) (Math.random() * columnCount)); return new Position(randomGenerator.nextInt(rowCount), randomGenerator.nextInt(columnCount));
} }
@Override @Override
...@@ -85,14 +85,15 @@ public class FirefighterBoard implements Board<List<ModelElement>> { ...@@ -85,14 +85,15 @@ public class FirefighterBoard implements Board<List<ModelElement>> {
private List<Position> activateFirefighters() { private List<Position> activateFirefighters() {
List<Position> result = new ArrayList<>(); List<Position> result = new ArrayList<>();
firefighterNewPositions = new ArrayList<>(); List<Position> firefighterNewPositions = new ArrayList<>();
for (Position firefighterPosition : firefighterPositions) { for (Position firefighterPosition : firefighterPositions) {
Position newFirefighterPosition = neighborClosestToFire(firefighterPosition); Position newFirefighterPosition = neighborClosestToFire(firefighterPosition);
result.add(firefighterPosition);
firefighterNewPositions.add(newFirefighterPosition); firefighterNewPositions.add(newFirefighterPosition);
extinguish(newFirefighterPosition); extinguish(newFirefighterPosition);
result.add(firefighterPosition);
result.add(newFirefighterPosition); result.add(newFirefighterPosition);
List<Position> neighborFirePositions = neighbors(newFirefighterPosition).stream().filter(firePositions::contains).toList(); List<Position> neighborFirePositions = neighbors(newFirefighterPosition).stream()
.filter(firePositions::contains).toList();
for(Position firePosition : neighborFirePositions) for(Position firePosition : neighborFirePositions)
extinguish(firePosition); extinguish(firePosition);
result.addAll(neighborFirePositions); result.addAll(neighborFirePositions);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment